Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20108 )
Change subject: IMPALA-12159: Support ORDER BY for collections of variable length types in select list ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Finally digested descriptors.cc too http://gerrit.cloudera.org:8080/#/c/20108/5/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: http://gerrit.cloudera.org:8080/#/c/20108/5/be/src/runtime/descriptors.cc@937 PS5, Line 937: const NonWritableBasicBlock& insert_before > I don't quite understand, it is already used on L958. oops, I missed that for some reason -- To view, visit http://gerrit.cloudera.org:8080/20108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic15b29393f260b572e11a8dbb9deeb8c02981852 Gerrit-Change-Number: 20108 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 13 Nov 2023 15:14:27 +0000 Gerrit-HasComments: Yes
