Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20318 )
Change subject: IMPALA-12306: (Part 2) Make codegen cache tests with symbol emitter more robust ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20318/4/be/src/codegen/codegen-symbol-emitter.cc File be/src/codegen/codegen-symbol-emitter.cc: http://gerrit.cloudera.org:8080/#/c/20318/4/be/src/codegen/codegen-symbol-emitter.cc@58 PS4, Line 58: stringstream s; > I am not very sure if we also need to consider the abnormal case non_freed_ I think it's a good idea to check it and doesn't make normal execution slower. I changed it to "non_freed_objects_ != 0" and also changed the error message. Removed the DCHECK as it is now superfluous. http://gerrit.cloudera.org:8080/#/c/20318/4/be/src/codegen/codegen-symbol-emitter.cc@64 PS4, Line 64: } else if (FLAGS_codegen_symbol_emitter_log_successful_destruction_test_only) { > nit. seems no need for the new line Done -- To view, visit http://gerrit.cloudera.org:8080/20318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61b9b0de9c896f3de7eb1be7de33d822b1ab70d0 Gerrit-Change-Number: 20318 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 13 Nov 2023 16:59:18 +0000 Gerrit-HasComments: Yes
