Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/20653 )
Change subject: IMPALA-12377: Improve count(*) performance for jdbc external table ...................................................................... Patch Set 2: (3 comments) Some nits. http://gerrit.cloudera.org:8080/#/c/20653/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20653/2//COMMIT_MSG@10 PS2, Line 10: Even nit: Even when there http://gerrit.cloudera.org:8080/#/c/20653/2//COMMIT_MSG@11 PS2, Line 11: adds nit: add rows http://gerrit.cloudera.org:8080/#/c/20653/2/be/src/exec/data-source-scan-node.cc File be/src/exec/data-source-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/20653/2/be/src/exec/data-source-scan-node.cc@354 PS2, Line 354: // TODO The timezone depends on flag New comments look a bit weird as we break multiple times before reaching the 90 char limit. Was that intentional? -- To view, visit http://gerrit.cloudera.org:8080/20653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9953dca949eb773022f1d6dcf48d8877857635d6 Gerrit-Change-Number: 20653 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 13 Nov 2023 23:49:31 +0000 Gerrit-HasComments: Yes
