Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 )
Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20498/6/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/20498/6/fe/src/main/java/org/apache/impala/service/Frontend.java@1816 PS6, Line 1816: Planner.reduceCardinalityByRuntimeFilter(planRoots); : Planner.computeProcessingCost(planRoots, result, planner.getPlannerCtx()); : Planner.computeResourceReqs(planRoots, queryCtx, result, : planner.getPlannerCtx(), planner.getAnalysisResult().isQueryStmt()); This cardinality reduction happen before cost and resource requirement calculation. It is possible that lower cardinality result in lower resource estimation, albeit only limited to ScanNode, JoinNode, and ExchangeNode. Having query option to disable/scale the cardinality reduction might be desirable to revert back to old behavior. -- To view, visit http://gerrit.cloudera.org:8080/20498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I033789c9b63a8188484e3afde8e646563918b3e1 Gerrit-Change-Number: 20498 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 14 Nov 2023 16:01:44 +0000 Gerrit-HasComments: Yes
