Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20591 )
Change subject: IMPALA-12505: Add flag for trusted domain check to use 'origin' if xff header is not set ...................................................................... IMPALA-12505: Add flag for trusted domain check to use 'origin' if xff header is not set This change defines a new impala flag called 'trusted_domain_empty_xff_header_use_origin', which modifies the trusted domain check to work as follows if the trusted_domain and trusted_domain_use_xff_header flags are set: If there is an X-Forwarded-For header in the request, the trusted domain check runs to the value derived from it, if there is no such header, then the check runs to the origin (the address sending the request). Note: If there is an X-Forwarded-For header in the request or the trusted_domain_use_xff_header flag or trusted_domain flag is not set, then the behavior is not changed. Tested with new custom cluster tests. Change-Id: I58e5d1119527139eafaa411b55517b10bf394bb2 Reviewed-on: http://gerrit.cloudera.org:8080/20591 Reviewed-by: Csaba Ringhofer <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> --- M be/src/rpc/authentication.cc M be/src/transport/THttpServer.cpp M be/src/util/webserver.cc M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java 5 files changed, 133 insertions(+), 0 deletions(-) Approvals: Csaba Ringhofer: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I58e5d1119527139eafaa411b55517b10bf394bb2 Gerrit-Change-Number: 20591 Gerrit-PatchSet: 5 Gerrit-Owner: Gergely Farkas <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
