Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 )
Change subject: IMPALA-3268: Add support for SHOW VIEWS statement ...................................................................... Patch Set 3: (4 comments) Hi all, I have addressed Quanlong's comments on the patch set 2. Please let me know if there are additional suggestions. I also triggered https://jenkins.impala.io/job/gerrit-verify-dryrun-external/2241/ against this patch to see if there are broken tests after patch set 3. http://gerrit.cloudera.org:8080/#/c/20669/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20669/2/be/src/service/client-request-state.cc@370 PS2, Line 370: return Status::OK(); > It seems the only difference between SHOW_VIEWS and the above SHOW_TABLES c Thanks Quanlong! Yes we could. I will merge them in the next patch. http://gerrit.cloudera.org:8080/#/c/20669/2/be/src/service/frontend.h File be/src/service/frontend.h: http://gerrit.cloudera.org:8080/#/c/20669/2/be/src/service/frontend.h@79 PS2, Line 79: std::set<TImpalaTableType::type>()); > We can set a default value as 'views_only=false' then don't need to overrid Thanks for the suggestion Quanlong! Based on a discussion offline, I will change this argument to a const reference to a std::set<TImpalaTableType::type> in the next patch set since it would make it easier to implement statements like SHOW MATERIALIZED VIEWS in a follow-up JIRA. http://gerrit.cloudera.org:8080/#/c/20669/2/fe/src/main/java/org/apache/impala/analysis/ShowTablesStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowTablesStmt.java: http://gerrit.cloudera.org:8080/#/c/20669/2/fe/src/main/java/org/apache/impala/analysis/ShowTablesStmt.java@43 PS2, Line 43: getPattern( > getPattern? Thanks for catching this Quanlong! I will some tests in ToSqlTest in the next patch set. http://gerrit.cloudera.org:8080/#/c/20669/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/20669/2/fe/src/main/java/org/apache/impala/service/Frontend.java@593 PS2, Line 593: } else if (analysis.isShowDbsStmt()) { > nit: move to the above line to be right after "} " Done -- To view, visit http://gerrit.cloudera.org:8080/20669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I321fc5350392a815949a4e7d2a64d60466689788 Gerrit-Change-Number: 20669 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 16 Nov 2023 01:07:38 +0000 Gerrit-HasComments: Yes
