Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20496 )
Change subject: IMPALA-12373: Small String Optimization for StringValue ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/20496/15/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: http://gerrit.cloudera.org:8080/#/c/20496/15/be/src/runtime/sorter.cc@392 PS15, Line 392: CollectNonNullNonSmallVarSlots(cur_tuple, &string_values, &collection_values_and_sizes, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/20496/15/be/src/runtime/tuple.cc File be/src/runtime/tuple.cc: http://gerrit.cloudera.org:8080/#/c/20496/15/be/src/runtime/tuple.cc@93 PS15, Line 93: // in a tuple we can assume that the rest of the strings are already smallified. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20496/15/be/src/util/in-list-filter.h File be/src/util/in-list-filter.h: http://gerrit.cloudera.org:8080/#/c/20496/15/be/src/util/in-list-filter.h@152 PS15, Line 152: const auto& res = values.emplace(v); line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/20496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741c3a5f12ab620b6b64b57d4c89b5f8e056efd3 Gerrit-Change-Number: 20496 Gerrit-PatchSet: 15 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 16 Nov 2023 19:52:43 +0000 Gerrit-HasComments: Yes
