Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20711 )

Change subject: IMPALA-12557: DELETE throws DateTimeParseException when 
deleting from time-partitioned table
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Carry +1

http://gerrit.cloudera.org:8080/#/c/20711/1/be/src/util/iceberg-utility-functions.h
File be/src/util/iceberg-utility-functions.h:

http://gerrit.cloudera.org:8080/#/c/20711/1/be/src/util/iceberg-utility-functions.h@17
PS1, Line 17:
> Add #pragma once
Done


http://gerrit.cloudera.org:8080/#/c/20711/1/be/src/util/iceberg-utility-functions.cc
File be/src/util/iceberg-utility-functions.cc:

http://gerrit.cloudera.org:8080/#/c/20711/1/be/src/util/iceberg-utility-functions.cc@34
PS1, Line 34:
> Clang tidy: unused
Done



--
To view, visit http://gerrit.cloudera.org:8080/20711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cfeaed6409289663eb0f65b1ee2ecebd93e6118
Gerrit-Change-Number: 20711
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 17 Nov 2023 12:46:23 +0000
Gerrit-HasComments: Yes

Reply via email to