Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 2:

(3 comments)

Left a few small comments, otherwise the change makes sense to me.

http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:

http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py@1437
PS2, Line 1437: 4
nit: magic constant


http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py@1443
PS2, Line 1443: 5s
Now it's 10s


http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py@1449
PS2, Line 1449: 4
nit: magic constant



--
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 17 Nov 2023 13:07:42 +0000
Gerrit-HasComments: Yes

Reply via email to