Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 )
Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction ...................................................................... Patch Set 11: (6 comments) http://gerrit.cloudera.org:8080/#/c/20498/7/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/20498/7/fe/src/main/java/org/apache/impala/planner/JoinNode.java@1025 PS7, Line 1025: isLeftOuterJoin > Left outer join may still eligible to be included in nodeStack if it is sel Another join type: shouldn't this be applicable to semi join? http://gerrit.cloudera.org:8080/#/c/20498/7/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/20498/7/fe/src/main/java/org/apache/impala/planner/ScanNode.java@488 PS7, Line 488: the least output cardinality > Added testRuntimeFilterCardinalityReduction. Thanks, it is much more understandable for me now! http://gerrit.cloudera.org:8080/#/c/20498/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test File testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test: http://gerrit.cloudera.org:8080/#/c/20498/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test@26 PS11, Line 26: ss_sold_date_sk = d_date_sk Can you add a test with more than 1 equi join predicates? http://gerrit.cloudera.org:8080/#/c/20498/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test@40 PS11, Line 40: |--01:SCAN HDFS [tpcds.store_returns] : | HDFS partitions=1/1 files=1 size=31.19MB : | row-size=16B cardinality=287.51K : | Would the planner also reduce build side scan node cardinality if there was a bloom filter consumed there? Can you add a test for this? http://gerrit.cloudera.org:8080/#/c/20498/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test@46 PS11, Line 46: RF000 -> ss_sold_date_sk Can you add an example with more than 1 runtime filters consumed by the scanner? http://gerrit.cloudera.org:8080/#/c/20498/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test@48 PS11, Line 48: DISTRIBUTEDPLAN Are the parallel/distributed plans useful in the tests? At the first glance they are just adding noise. -- To view, visit http://gerrit.cloudera.org:8080/20498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I033789c9b63a8188484e3afde8e646563918b3e1 Gerrit-Change-Number: 20498 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 17 Nov 2023 16:21:15 +0000 Gerrit-HasComments: Yes
