Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 )
Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction ...................................................................... Patch Set 12: (4 comments) patch set 12 change the workload of testRuntimeFilterCardinalityReduction to tpcds_parquet to include row-level runtime filter for cardinality reduction. http://gerrit.cloudera.org:8080/#/c/20498/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test File testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test: http://gerrit.cloudera.org:8080/#/c/20498/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test@26 PS11, Line 26: ss_sold_date_sk = d_date_sk > Can you add a test with more than 1 equi join predicates? Add test that add extra predicate (sr_returned_date_sk = d_date_sk predicate). http://gerrit.cloudera.org:8080/#/c/20498/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test@40 PS11, Line 40: |--01:SCAN HDFS [tpcds_parquet.store_returns] : | HDFS partitions=1/1 files=1 size=15.43MB : | row-size=16B cardinality=287.51K : | > Would the planner also reduce build side scan node cardinality if there was Add test that also join against time_dim for this. Build side should see no cardinality reduction if it is scan node only. http://gerrit.cloudera.org:8080/#/c/20498/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test@46 PS11, Line 46: RF001 -> ss_sold_date_sk > Can you add an example with more than 1 runtime filters consumed by the sca In the new test that also join against time_dim, cardinality estimate reduced further to 61. http://gerrit.cloudera.org:8080/#/c/20498/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test@48 PS11, Line 48: > Are the parallel/distributed plans useful in the tests? At the first glance Removed DISTRIBUTEDPLAN and PARALLELPLANS. -- To view, visit http://gerrit.cloudera.org:8080/20498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I033789c9b63a8188484e3afde8e646563918b3e1 Gerrit-Change-Number: 20498 Gerrit-PatchSet: 12 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 17 Nov 2023 20:07:51 +0000 Gerrit-HasComments: Yes
