Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20719 )
Change subject: WIP: Share compressor in KrpcDataStreamSender ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/20719/3/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/20719/3/be/src/runtime/krpc-data-stream-sender.cc@167 PS3, Line 167: Status Init(RuntimeState* state, std::shared_ptr<CharMemTrackerAllocator> allocator, OutboundRowBatch::Serializer* serializer); line too long (129 > 90) http://gerrit.cloudera.org:8080/#/c/20719/3/be/src/runtime/krpc-data-stream-sender.cc@378 PS3, Line 378: RuntimeState* state, std::shared_ptr<CharMemTrackerAllocator> allocator, OutboundRowBatch::Serializer* serializer) { line too long (120 > 90) http://gerrit.cloudera.org:8080/#/c/20719/3/be/src/runtime/krpc-data-stream-sender.cc@819 PS3, Line 819: outbound_batches_.emplace_back(char_mem_tracker_allocator_, serializer_/*.get()*/, is_local); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/20719/3/be/src/runtime/krpc-data-stream-sender.cc@1208 PS3, Line 1208: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20719/3/be/src/util/compress.cc File be/src/util/compress.cc: http://gerrit.cloudera.org:8080/#/c/20719/3/be/src/util/compress.cc@349 PS3, Line 349: const int acceleration = 1; line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/20719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64854a350a9dae8bf3af11c871882ea4750e60b3 Gerrit-Change-Number: 20719 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2023 17:42:42 +0000 Gerrit-HasComments: Yes
