Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 )
Change subject: IMPALA-3268: Add support for SHOW VIEWS statement ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/20669/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20669/5//COMMIT_MSG@7 PS5, Line 7: IMPALA-3268: Add support for SHOW VIEWS statement The ticket mentions having a way to get both tables and views in a single call, presumably to be able to access the existing behavior. I don't see that implemented here. This changes SHOW TABLES to no longer include views, right? http://gerrit.cloudera.org:8080/#/c/20669/5/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20669/5/be/src/service/client-request-state.cc@366 PS5, Line 366: std::set<TImpalaTableType::type> table_types = params->table_types; Can we take a ref of table_types? I don't see any reason to make a copy here. Or just pass it directly to GetTableNames. http://gerrit.cloudera.org:8080/#/c/20669/5/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/20669/5/common/thrift/CatalogService.thrift@530 PS5, Line 530: UNKNOWN, UNKNOWN seems like it should come after other types. Do we rely on that anywhere? -- To view, visit http://gerrit.cloudera.org:8080/20669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I321fc5350392a815949a4e7d2a64d60466689788 Gerrit-Change-Number: 20669 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2023 18:28:48 +0000 Gerrit-HasComments: Yes
