Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20723
Change subject: IMPALA-12571: Fix data race in CreateTemplateTuple ...................................................................... IMPALA-12571: Fix data race in CreateTemplateTuple When multiple scanner threads create template tuples they invoke Tuple::DeepCopy() concurrently which invoke StringValue::Smallify(), hence we end up having a data race on the StringValue object. This CR changes Tuple::DeepCopy() to only modified the copied tuple and leave the source tuple untouched. Testing: * verified the solution in TSAN build Change-Id: I51d48b79bde0a5ae0103a780f9c09f3003ed157e --- M be/src/runtime/tuple.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/20723/1 -- To view, visit http://gerrit.cloudera.org:8080/20723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I51d48b79bde0a5ae0103a780f9c09f3003ed157e Gerrit-Change-Number: 20723 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
