Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20710 )
Change subject: IMPALA-12471: Add unit tests of external jdbc tables for MySQL ...................................................................... Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/20710/9/testdata/bin/clean-mysql-env.sh File testdata/bin/clean-mysql-env.sh: http://gerrit.cloudera.org:8080/#/c/20710/9/testdata/bin/clean-mysql-env.sh@20 PS9, Line 20: This script create and load the jdbc data source target table in Postgres nit: update description http://gerrit.cloudera.org:8080/#/c/20710/9/testdata/bin/clean-mysql-env.sh@27 PS9, Line 27: Should we turn down mysql server? http://gerrit.cloudera.org:8080/#/c/20710/9/testdata/bin/create-ext-mysql-data-source-table.sql File testdata/bin/create-ext-mysql-data-source-table.sql: http://gerrit.cloudera.org:8080/#/c/20710/9/testdata/bin/create-ext-mysql-data-source-table.sql@1 PS9, Line 1: -- Don't need this script http://gerrit.cloudera.org:8080/#/c/20710/9/testdata/bin/setup-mysql-env.sh File testdata/bin/setup-mysql-env.sh: http://gerrit.cloudera.org:8080/#/c/20710/9/testdata/bin/setup-mysql-env.sh@20 PS9, Line 20: This script create and load the jdbc data source target table in Postgres. nit: update description http://gerrit.cloudera.org:8080/#/c/20710/9/testdata/bin/setup-mysql-env.sh@33 PS9, Line 33: sudo remove all "sudo" in this script http://gerrit.cloudera.org:8080/#/c/20710/9/testdata/bin/setup-mysql-env.sh@139 PS9, Line 139: # Create data source tables (alltypes_jdbc_datasource and : # alltypes_jdbc_datasource_2). : ${IMPALA_HOME}/bin/impala-shell.sh -f\ : ${IMPALA_HOME}/testdata/bin/create-ext-mysql-data-source-table.sql Don't need to create data source and table here http://gerrit.cloudera.org:8080/#/c/20710/9/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/20710/9/tests/custom_cluster/test_ext_data_sources.py@23 PS9, Line 23: import subprocess move this line to line #21 -- To view, visit http://gerrit.cloudera.org:8080/20710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446ec3d4ebaf53c8edac0b2d181514bde587dfae Gerrit-Change-Number: 20710 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 27 Nov 2023 04:18:59 +0000 Gerrit-HasComments: Yes
