Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20367 )

Change subject: IMPALA-10976: Sync db/table to latest HMS event for all DDL/DMLs
......................................................................


Patch Set 10:

(27 comments)

http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py
File tests/custom_cluster/test_sync_to_latest_hms_events.py:

http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@21
PS10, Line 21: import itertools
flake8: F401 'itertools' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@22
PS10, Line 22: import pytest
flake8: F401 'pytest' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@24
PS10, Line 24: import time
flake8: F401 'time' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@26
PS10, Line 26: from beeswaxd.BeeswaxService import QueryState
flake8: F401 'beeswaxd.BeeswaxService.QueryState' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@27
PS10, Line 27: from copy import deepcopy
flake8: F401 'copy.deepcopy' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@29
PS10, Line 29: from tests.beeswax.impala_beeswax import ImpalaBeeswaxException
flake8: F401 'tests.beeswax.impala_beeswax.ImpalaBeeswaxException' imported but 
unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@31
PS10, Line 31: from tests.common.file_utils import create_table_from_orc
flake8: F401 'tests.common.file_utils.create_table_from_orc' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@32
PS10, Line 32: from tests.common.impala_test_suite import LOG
flake8: F401 'tests.common.impala_test_suite.LOG' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@34
PS10, Line 34: from tests.common.skip import (SkipIf, SkipIfFS, SkipIfKudu, 
SkipIfLocal,
flake8: F401 'tests.common.skip.SkipIfCatalogV2' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@34
PS10, Line 34: from tests.common.skip import (SkipIf, SkipIfFS, SkipIfKudu, 
SkipIfLocal,
flake8: F401 'tests.common.skip.SkipIfHive2' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@34
PS10, Line 34: from tests.common.skip import (SkipIf, SkipIfFS, SkipIfKudu, 
SkipIfLocal,
flake8: F401 'tests.common.skip.SkipIf' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@34
PS10, Line 34: from tests.common.skip import (SkipIf, SkipIfFS, SkipIfKudu, 
SkipIfLocal,
flake8: F401 'tests.common.skip.SkipIfKudu' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@36
PS10, Line 36: from tests.common.test_dimensions import 
create_single_exec_option_dimension
flake8: F401 'tests.common.test_dimensions.create_single_exec_option_dimension' 
imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@37
PS10, Line 37: from tests.common.test_dimensions import 
(create_exec_option_dimension,
flake8: F401 'tests.common.test_dimensions.create_client_protocol_dimension' 
imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@37
PS10, Line 37: from tests.common.test_dimensions import 
(create_exec_option_dimension,
flake8: F401 'tests.common.test_dimensions.create_exec_option_dimension' 
imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@40
PS10, Line 40: from tests.common.test_vector import ImpalaTestDimension
flake8: F401 'tests.common.test_vector.ImpalaTestDimension' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@41
PS10, Line 41: from tests.util.filesystem_utils import (
flake8: F401 'tests.util.filesystem_utils.FILESYSTEM_NAME' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@50
PS10, Line 50: from tests.common.impala_cluster import ImpalaCluster
flake8: F401 'tests.common.impala_cluster.ImpalaCluster' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@51
PS10, Line 51: from tests.util.filesystem_utils import FILESYSTEM_PREFIX
flake8: F401 'tests.util.filesystem_utils.FILESYSTEM_PREFIX' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@53
PS10, Line 53: def get_trash_path(bucket, path):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@59
PS10, Line 59: class TestSyncToLatestHmsEvents(CustomClusterTestSuite):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@115
PS10, Line 115: y
flake8: E501 line too long (91 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@223
PS10, Line 223: @
flake8: E303 too many blank lines (2)


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@293
PS10, Line 293: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@294
PS10, Line 294: ;
flake8: E703 statement ends with a semicolon


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@321
PS10, Line 321: n
flake8: F841 local variable 'num_parts' is assigned to but never used


http://gerrit.cloudera.org:8080/#/c/20367/10/tests/custom_cluster/test_sync_to_latest_hms_events.py@642
PS10, Line 642:
flake8: W292 no newline at end of file



--
To view, visit http://gerrit.cloudera.org:8080/20367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia250d0a943838086c187e5cb7c60035e5a564bbf
Gerrit-Change-Number: 20367
Gerrit-PatchSet: 10
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Thu, 30 Nov 2023 21:57:31 +0000
Gerrit-HasComments: Yes

Reply via email to