Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20664 )
Change subject: IMPALA-?????: First commit for experimental Calcite planner ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/20664/8/java/experimental-planner/src/main/java/org/apache/impala/calcite/service/ExecRequestCreator.java File java/experimental-planner/src/main/java/org/apache/impala/calcite/service/ExecRequestCreator.java: http://gerrit.cloudera.org:8080/#/c/20664/8/java/experimental-planner/src/main/java/org/apache/impala/calcite/service/ExecRequestCreator.java@111 PS8, Line 111: // compute resource requirements of the final plan Can you add call to Planner.computeProcessingCost() right before Planner.computeResourceReqs()? https://github.com/apache/impala/blob/c21e5212b73d4b51cd93e8080de69d3dee7bbfb7/fe/src/main/java/org/apache/impala/service/Frontend.java#L1816 It will probably becomes a no-op for now. I'm just curious if it breaks or not. It seems some codes still need to be copied from Frontend.getTExecRequest() to actually allow replanning and executor group set reassignment, and that can wait. -- To view, visit http://gerrit.cloudera.org:8080/20664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I850679424d002c8acccb7421792ad9c498f3c8ab Gerrit-Change-Number: 20664 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 30 Nov 2023 22:07:29 +0000 Gerrit-HasComments: Yes
