Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20692 )
Change subject: IMPALA-11542: Implement pre-allocation in LLVM memory manager ...................................................................... IMPALA-11542: Implement pre-allocation in LLVM memory manager Implements up-front allocation for the LLVM memory manager to avoid disparate sections on ARM which can exceed the 4GB limit for ADRP instructions and crash (or hit an assertion in debug mode). This is an LLVM issue that we're fixing by providing a custom memory manager. See the JIRA and https://discourse.llvm.org/t/llvm-rtdyld-aarch64-abi-relocation-restrictions/74616 for further discussion. Testing: - passes debug test run on ARM - pre-commit tests Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675 Reviewed-on: http://gerrit.cloudera.org:8080/20692 Tested-by: Michael Smith <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> --- M be/src/thirdparty/llvm/SectionMemoryManager.cpp M be/src/thirdparty/llvm/SectionMemoryManager.h 2 files changed, 122 insertions(+), 0 deletions(-) Approvals: Michael Smith: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675 Gerrit-Change-Number: 20692 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
