Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT] DISTINCT FROM in HiveSqlWriter ......................................................................
IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT] DISTINCT FROM in HiveSqlWriter IMPALA-4100: * Postgres and Impala support EXTRACT([field] from [date-type]), but Hive doesn't * Hive has other UDFs that perform the same function, but they have different names * This commit modifies the HiveSqlWriter to use the corresponding Hive functions IMPALA-4112: * Postgres and Impala support IS [NOT] DISTINCT FROM clauses as a null safe equals * Hive doesn't support this clause, but has a null safe equals operator: <=> * This commit modifies the HiveSqlWriter to use <=> instead of IS [NOT] DISTINCT FROM Testing: * This commit only modifies the HiveSqlWriter, so no testing against Impala was done * Tested locally against Hive Change-Id: I3922ca61af59ecd2899c911b1a03e11ab5c26e11 Reviewed-on: http://gerrit.cloudera.org:8080/4357 Reviewed-by: Michael Brown <[email protected]> Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Tim Armstrong <[email protected]> --- M tests/comparison/model_translator.py 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: Michael Brown: Looks good to me, but someone else must approve Tim Armstrong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3922ca61af59ecd2899c911b1a03e11ab5c26e11 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: [email protected]
