Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h File be/src/util/blocking-queue.h: PS3, Line 188: put_list > shouldn't these members have _ at the end? I just converted this to a struct :-). Line 197: boost::mutex get_lock; > Shouldn't we align get_lock? It's implicitly aligned after I added the attribute to ConditionVariable as the compiler seems to pad that struct to 64-byte. I will add to DCHECK to verify that's the case. http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/condition-variable.h File be/src/util/condition-variable.h: Line 28: /// Simple wrapper around POSIX pthread condition variable. > Explain briefly how it differs from the boost cv? Sure. PS3, Line 29: __attribute__ ((aligned(64))) > What do you think about putting this in compiler-util.h as CACHE_ALIGN or s Good idea. PS3, Line 29: struct > class? Can you actually put __attribute__ ((aligned(64))) on class in C++ ? PS3, Line 61: cv > cv_ I think struct requires no "_" ?! -- To view, visit http://gerrit.cloudera.org:8080/4350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4cf351455efefb0f3bb791cf9bc82d1421d54 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Chen Huang <paulhuan...@utexas.edu> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
