Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4028: Trim sentry config file path spaces while impala 
start.
......................................................................


Patch Set 3:

I don't think we should go ahead with the trimming solution for the reasons I 
mentioned earlier (problems with trying to "fix" misconfigurations and 
inconsistency with other command line options). 

However part of the problem seems to be that it's very hard to see the spaces 
in the error message. Maybe you could change the patch just to quote the file 
name in the error message?

-- 
To view, visit http://gerrit.cloudera.org:8080/4309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a76b9e4236caa3f2088fba8a9cf0236fced2634
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: davy...@163.com
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: davy...@163.com
Gerrit-HasComments: No

Reply via email to