Alex Behm has posted comments on this change.

Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.
......................................................................


Patch Set 3:

(3 comments)

Looks good to me.

Can we please separate the tool integration from the fixes in two separate 
patches?

http://gerrit.cloudera.org:8080/#/c/4361/3/bin/check-rat-report.py
File bin/check-rat-report.py:

Line 21: # Usage:
Can you describe the purpose of this tool? Where did this script come from?


Line 24: #      `git archive --prefix=Foo/ -o baz.tar.gz HEAD`
can we make the examples more concrete?


http://gerrit.cloudera.org:8080/#/c/4361/3/testdata/bin/cache_tables.py
File testdata/bin/cache_tables.py:

Line 22: # query.  This only works on a mini-dfs cluster.  This is remarkably 
difficult to do 
fix whitespace while here


-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to