Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-1702: Enforce unique table ID
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java:

Line 188:     private final HashMap<TTableName, TableId> tblIdMap_ =
> Why do we need another map? Don't we already have a map of existing tables 
+1. Given this happens only with "invalidate metadata", how about we change 
just the reset() to re-use existing Ids (by looking up from the existing 
dbCache, rather than resetting to 0) and other places just uses a new unique 
id. This solves two issues.

1. Invalidate won't change the Id.
2. drop+create of same table creates a new Id.

Going by Tim's stats, if we use a 64-bit, we can use an ever-increasing Id. 
Thoughts?


-- 
To view, visit http://gerrit.cloudera.org:8080/4349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <h...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <h...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to