Huaisi Xu has posted comments on this change.

Change subject: IMPALA-1702: Enforce unique table ID
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java:

Line 188:     private final HashMap<TTableName, TableId> tblIdMap_ =
> I think it may be hard to differentiate between a table dropped + added and
why we want to differentiate this? we do not do this now as well right?


Line 188:     private final HashMap<TTableName, TableId> tblIdMap_ =
> I think that behavior is actually desired. If a table with the same name wa
yeah, but ideally any table change should trigger a new analyzing just like 
incomplete table would do in the middle of analyze. so we do not have the case 
when for 100 sub queries, half of them are analyzed based on table version a, 
the second half on version b. and backend ends up with two version of the same 
table as well. If we keep them the same table ID for the same table name, then 
at least backend can do things on a single version of table? I know that may 
not matter.. anyway, I will do what you guys suggested... thanks


-- 
To view, visit http://gerrit.cloudera.org:8080/4349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <h...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <h...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to