Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


IMPALA-4091: Fix backend unit to log in logs/be_tests.

1. Many backend unit tests did not follow proper initialization
using InitCommonRuntime(), and as a result did not write their
logs into the logs/be_tests directory.

2. Added an IMPALA_TEST_MAIN() macro that stamps out the common
main() function used in most gtest unit tests.

3. Tests added via ADD_UDF_TEST in a CMakeLists.txt did not
have the logging dir set up properly.

Testing: I validated that every test produces a corresponding
.INFO file in logs/be_tests. The only exception is promise-test
for which I added a TODO since the fix seems non-trivial.

Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Reviewed-on: http://gerrit.cloudera.org:8080/4352
Reviewed-by: Alex Behm <alex.b...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/atomic-test.cc
M be/src/common/init.h
M be/src/exec/delimited-text-parser-test.cc
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/incr-stats-util-test.cc
M be/src/exec/incr-stats-util.cc
M be/src/exec/old-hash-table-test.cc
M be/src/exec/parquet-plain-test.cc
M be/src/exec/parquet-version-test.cc
M be/src/exec/read-write-util-test.cc
M be/src/exec/row-batch-list-test.cc
M be/src/exec/zigzag-test.cc
M be/src/experiments/string-search-sse-test.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-util-test.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/collection-value-builder-test.cc
M be/src/runtime/decimal-test.cc
M be/src/runtime/free-pool-test.cc
M be/src/runtime/free-pool.h
M be/src/runtime/hdfs-fs-cache-test.cc
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-tracker-test.cc
M be/src/runtime/multi-precision-test.cc
M be/src/runtime/parallel-executor-test.cc
M be/src/runtime/raw-value-test.cc
M be/src/runtime/row-batch-serialize-test.cc
M be/src/runtime/string-buffer-test.cc
M be/src/runtime/string-value-test.cc
M be/src/runtime/thread-resource-mgr-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/scheduling/backend-config-test.cc
M be/src/scheduling/simple-scheduler-test.cc
M be/src/service/hs2-util-test.cc
M be/src/service/query-options-test.cc
M be/src/service/session-expiry-test.cc
M be/src/testutil/gtest-util.h
M be/src/udf/uda-test.cc
M be/src/udf/udf-test.cc
M be/src/util/benchmark-test.cc
M be/src/util/bit-util-test.cc
M be/src/util/bitmap-test.cc
M be/src/util/blocking-queue-test.cc
M be/src/util/bloom-filter-test.cc
M be/src/util/coding-util-test.cc
M be/src/util/debug-util-test.cc
M be/src/util/decompress-test.cc
M be/src/util/dict-test.cc
M be/src/util/error-util-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/fixed-size-hash-table-test.cc
M be/src/util/internal-queue-test.cc
M be/src/util/logging-support-test.cc
M be/src/util/lru-cache-test.cc
M be/src/util/metrics-test.cc
M be/src/util/parse-util-test.cc
M be/src/util/perf-counters-test.cc
M be/src/util/pretty-printer-test.cc
M be/src/util/promise-test.cc
M be/src/util/redactor-config-parser-test.cc
M be/src/util/redactor-test.cc
M be/src/util/redactor-unconfigured-test.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/string-parser-test.cc
M be/src/util/symbols-util-test.cc
M be/src/util/thread-pool-test.cc
M be/src/util/uid-util-test.cc
M be/src/util/webserver-test.cc
73 files changed, 169 insertions(+), 421 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>

Reply via email to