Marcel Kornacker has posted comments on this change. Change subject: Remove Llama support. ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/query-schedule.h File be/src/scheduling/query-schedule.h: Line 86: int16_t GetPerHostVCores() const; what about this? have you done a global search for vcores? http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/request-pool-service.cc File be/src/scheduling/request-pool-service.cc: Line 47: DEFINE_string(llama_site_path, "", "Path to the Llama configuration file " what about this? also, it looks like the header has a bunch of llama references that should be removed. Line 136: jstring llama_site_path = ? http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/simple-scheduler.cc File be/src/scheduling/simple-scheduler.cc: Line 292 what's going on here? http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 243 unclear how this is related to llama -- To view, visit http://gerrit.cloudera.org:8080/4445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
