Henry Robinson has posted comments on this change. Change subject: IMPALA-4053: Address follow up comments for IMPALA-3610 ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4306/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 2090: state->AssignOutgoingFilter(params, filter_mem_tracker_.get(), rpc_params.get()); > i think you're over-finessing this. if a single 8mb filter makes the query That may be true - but just a reminder that filters may (theoretically) be up to 512MB big, so we're not just concerned with the situation where the query is teetering right on the edge of over-consumption. -- To view, visit http://gerrit.cloudera.org:8080/4306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7499558cc9d3622a9f3b68904aa5fe92a113f579 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
