Henry Robinson has posted comments on this change.

Change subject: IMPALA-4160: Remove Llama support.
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/query-schedule.cc
File be/src/scheduling/query-schedule.cc:

PS1, Line 112: bool ignored;
> can we print "deprecated" somewhere?
There's not an obvious place to do that; the only warning mechanism I can see 
is the RuntimeState's log which we don't have access to here. Printing a 
warning here to the process log wouldn't really help (users don't look at logs, 
operations staff do). Returning a bad status from parsing the query options 
would abort everything.  Perhaps the best thing to do is to somehow hide the 
query options from clients (so they can still be set, but not shown).


http://gerrit.cloudera.org:8080/#/c/4445/4/common/thrift/Frontend.thrift
File common/thrift/Frontend.thrift:

Line 390:   // TODO: Remove this and associated code in Planner.
> also add a todo in Planner.java, it's too easy to overlook here
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to