Jim Apple has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4187/3/testdata/cluster/.gitignore File testdata/cluster/.gitignore: PS3, Line 1: cdh I'm not sure about this one. I don't want to have to add one of these for every or any new Hadoop vendor. http://gerrit.cloudera.org:8080/#/c/4187/1/testdata/pom.xml File testdata/pom.xml: > Similar to the other xml files, I don't know what to do here. This is a big patch - maybe file a new bug to de-Cloudera all the poms? http://gerrit.cloudera.org:8080/#/c/4187/3/tests/comparison/leopard/impala_docker_env.py File tests/comparison/leopard/impala_docker_env.py: Line 34: DEFAULT_BRANCH_NAME = 'origin/cdh5-trunk' Whether IMPALA-4085 is fixed, we should remove these. Who owns docker builds these days? -- To view, visit http://gerrit.cloudera.org:8080/4187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb37e2ef0cd9fa0e581d359c5dd3db7812b7b2c8 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
