stak...@cloudera.com has posted comments on this change.

Change subject: IMPALA-4101: qgen: Hive join predicates should only contains 
equality functions
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4419/4/tests/comparison/query_generator.py
File tests/comparison/query_generator.py:

PS4, Line 1369: signature
> s/functions/signatures/
Done


http://gerrit.cloudera.org:8080/#/c/4419/4/tests/comparison/tests/hive/test_create_join_clause.py
File tests/comparison/tests/hive/test_create_join_clause.py:

PS4, Line 25: 
> Nit: this test is hive-specific, so hive should be in the test name.
Done


PS4, Line 31: 
> FakeHiveQueryProfile
Done


PS4, Line 55: 
> Nit: This isn't a mock object; it's a real QueryGenerator. I would just cal
Done


PS4, Line 60: 
> Any thoughts on maybe parametrizing this test to test with different types?
I think its worth doing, but would rather do it in a separate test that isn't 
Hive specific. This test is solely responsible for checking if equality joins 
are made for Hive or not. I think testing if the join clause is correctly made 
with different column types would go in a separate test.

I'm working on a few unit tests for create_relational_join_condition and 
_create_boolean_func_tree that are not Hive specific and will incorporate your 
suggestions there (will be in a separate Gerrit review).


-- 
To view, visit http://gerrit.cloudera.org:8080/4419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8832a03cfa0d7ecc293ec6db6db2bcb34ab459
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: stak...@cloudera.com
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-Reviewer: stak...@cloudera.com
Gerrit-HasComments: Yes

Reply via email to