Dan Hecht has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation ......................................................................
Patch Set 9: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4163/6/be/src/service/child-query.h File be/src/service/child-query.h: PS6, Line 170: d prevents any more from starting. > I mentioned this in the class comment but will also mention here and in Wai What I mean is it'd be better to say that rather than "execution thread has exited" since the presence of an execution thread is an implementation detail. http://gerrit.cloudera.org:8080/#/c/4163/9/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: Line 434: // do not set up coordinator. rather than explaining what the code does, explain why. -- To view, visit http://gerrit.cloudera.org:8080/4163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe3024803e03595ee69c47759b58e8443d7bd167 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
