Amos Bird has posted comments on this change.

Change subject: IMPALA-1654: General partition exprs in DDL operations.
......................................................................


Patch Set 17:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3942/17/fe/src/main/java/com/cloudera/impala/analysis/AlterTableSetCachedStmt.java
File fe/src/main/java/com/cloudera/impala/analysis/AlterTableSetCachedStmt.java:

PS17, Line 32: [PARTITION partitionSpec] 
> nit: requires update? (here and elsewhere)
Done


http://gerrit.cloudera.org:8080/#/c/3942/17/fe/src/main/java/com/cloudera/impala/planner/HdfsPartitionPruner.java
File fe/src/main/java/com/cloudera/impala/planner/HdfsPartitionPruner.java:

PS17, Line 88: Used by some ALTER TABLE statements which need partition pruning.
> Remove. We might use it else where in the future, so this stmt might be sta
Done


http://gerrit.cloudera.org:8080/#/c/3942/17/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java:

PS17, Line 413: addTableToCatalogUpdate(refreshedTable, response.result)
> Shouldn't this go into the above if block?
Thanks! I have no idea why this statement comes out :)


-- 
To view, visit http://gerrit.cloudera.org:8080/3942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f
Gerrit-PatchSet: 17
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Amos Bird <amosb...@gmail.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Amos Bird <amosb...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to