stak...@cloudera.com has posted comments on this change.

Change subject: IMPALA-4101: qgen: Hive join predicates should only contains 
equality functions
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4419/5/tests/comparison/query_generator.py
File tests/comparison/query_generator.py:

Line 1436:         if self.profile.only_use_equality_join_predicates():
> I don't think this whole patch is necessary. We just need only_use_equality
That was my original approach, but this parameter does not fully work. If 
and_or_count and relational_count are drained to 0, then the code hits line 
1453 and any function could be chosen (including say a < or > operator), which 
could cause Hive to break.

I tried to add this same check to line 1453 but that didn't work because it 
only allows Equals.signatures, which eliminates the possibility of having any 
function in the JOIN clause (e.g ABS, FLOOR, CEIL, etc.)


-- 
To view, visit http://gerrit.cloudera.org:8080/4419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8832a03cfa0d7ecc293ec6db6db2bcb34ab459
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: stak...@cloudera.com
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-Reviewer: stak...@cloudera.com
Gerrit-HasComments: Yes

Reply via email to