Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3902: Scheduler improvements for running multiple 
fragment instances on a single backend

Patch Set 12:


Re: testing:
I think a stress test run would be very helpful.
How are the new Mt paths exercised?
File be/src/runtime/

PS10, Line 294: boost
> a complete overhaul of is out of scope.
Sure, I just figured it'd be nice to clean up if it were easy.

PS10, Line 2083: rorLogMap merged;
> yes
can you mention that? It's hard to keep track of all the TODOs, it'll make it a 
bit easier when we come back to fix some of this.
File be/src/scheduling/query-schedule.h:

PS10, Line 90:  shared across fragment instances
> not sure what you mean.
This owns the vector of fragment instance exec params, so I think it's 
confusing that this is defined as the parameters _shared across frag instances_.

How about something like:
"Execution parameters for the fragment; Includes parameters that are shared 
across fragment instances and owns the per-instance FInstanceExecParams."?
File be/src/scheduling/query-schedule.h:

Line 192:   /// Map node ids to the index of their node inside their plan.nodes 
TODO-MT: remove, only needed on the ST path

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I240445199e22f009f4e72fdb8754eb8d77e3d680
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-HasComments: Yes

Reply via email to