Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4497/1/be/src/runtime/buffered-block-mgr.cc File be/src/runtime/buffered-block-mgr.cc: PS1, Line 1325: ScratchFileUsed > ScratchFileBytesUsed? or ScratchFileBytes? (When TUnit::BYTES, looks like w Done PS1, Line 1344: returning in an error > I'm not sure what this is saying. Removed the confusing bit, I don't think it was helpful. -- To view, visit http://gerrit.cloudera.org:8080/4497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf8842626ded1345b632a0ccdb9a580e6a0ad470 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes