Lars Volker has posted comments on this change.

Change subject: IMPALA-4193: Warn when benchmarks run with sub-optimal CPU 
settings
......................................................................


Patch Set 3:

(6 comments)

Thanks for the review. Please see PS3.

http://gerrit.cloudera.org:8080/#/c/4528/1//COMMIT_MSG
Commit Message:

PS1, Line 9: Change-Id: I5e879cb35cf736f6112c1caed829722a38849794
> Doesn't this solve that issue?
You're right, it does.


http://gerrit.cloudera.org:8080/#/c/4528/1/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

PS1, Line 149: 
> This is the default, right?
It is, removed it here and elsewhere in the file.


PS1, Line 151:     LOG(ERROR) << "CPU does not support the Supplemental SSE3 
(SSSE3) instruction set. "
             :                << "This setup is generally unsupported and 
Impala might be unstable.";
             :   }
             : }
             : 
             : void CpuInfo::V
> This is in the other method, too; can you factor it out?
Done


Line 158:     string governor_file =
> Can you use a C==-style == here?
Done


Line 172:   string turbo_file = "/sys/devices/system/cpu/intel_pstate/no_turbo";
> here also, you could compare to "1", right?
Yes, done.


Line 173:   string turbo_off;
> Explain why this matters - it can ramp-up and down performance dynamically
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e879cb35cf736f6112c1caed829722a38849794
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to