Tim Armstrong has posted comments on this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output ......................................................................
Patch Set 1: (2 comments) This seems reasonable to me. I think we should get Alex Behm to confirm, since he was the one who originally wrote some of this code. How did you determine all the places that needed to be changed? We should also fix this for "SHOW CREATE FUNCTION" and any other similar statements that output SQL for consistency. The CREATE TABLE expected output is probably coming from .test files. E.g. testdata/workloads/functional-query/queries/QueryTest/kudu-show-create.test http://gerrit.cloudera.org:8080/#/c/4527/1/fe/src/main/java/com/cloudera/impala/analysis/ToSqlUtils.java File fe/src/main/java/com/cloudera/impala/analysis/ToSqlUtils.java: PS1, Line 72: reassamble reassemble Line 73: // This is safe, because periods are not allowed inside identifier names for Thanks for the explanation. -- To view, visit http://gerrit.cloudera.org:8080/4527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e66439daa35d2e3725e7277c16f3cc5fdb6f128 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <z...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Ivanfi <z...@cloudera.com> Gerrit-HasComments: Yes
