Jim Apple has posted comments on this change.

Change subject: IMPALA-4193: Warn when benchmarks run with sub-optimal CPU 
settings
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4528/5/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

Line 178:   DCHECK(initialized_);
> I noticed that setting the governor to performance will set the no_turbo fl
Either way is OK with me, though if you mention it one place, you might want to 
mention it both places.


-- 
To view, visit http://gerrit.cloudera.org:8080/4528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e879cb35cf736f6112c1caed829722a38849794
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to