Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests
......................................................................


IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests

The TestEnv used for the backend tests does not connect up the
MemTracker hierarchy in the expected way. This caused the valid
DCHECK in ConsumeLocal() to be triggered in backend tests.

This change fixes TestEnv to set up MemTrackers with the normal
hierarchy, as shown below, and fixes the tests to deal with the fallout
of that.

(Process)
 |
(Query)----------
 |              |
(Block Mgr) (Fragment instance)

Change-Id: Iadcbe96a9f1bf19872436211b049cebf39b0afe7
Reviewed-on: http://gerrit.cloudera.org:8080/4531
Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exec/hash-table-test.cc
M be/src/runtime/buffered-block-mgr-test.cc
M be/src/runtime/buffered-block-mgr.h
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/mem-tracker.h
M be/src/runtime/test-env.cc
M be/src/runtime/test-env.h
7 files changed, 135 insertions(+), 119 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iadcbe96a9f1bf19872436211b049cebf39b0afe7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

Reply via email to