Hello Michael Brown,

I'd like you to reexamine a change.  Please visit


to look at the new patch set (#12).

Change subject: IMPALA-3980: qgen: re-enable Hive as a target database

IMPALA-3980: qgen: re-enable Hive as a target database


* Added hive cli options back in (removed in commit "Stress test: Various 
* Modifications so that if --use-hive is specified, a Hive connection is 
actually created
* A few minor bug fixes so that the RQG can be run locally
* Modified MiniCluster to use HADOOP_CONF_DIR and HIVE_CONF_DIR rather than a 
file under IMPALA_HOME
* Fixed fe/src/test/resources/hive-default.xml so that it is a valid XML file, 
it was
missing a few element terminators that cause an exception in the cluster.py file


* Hive integration tested locally by invoking the data generator via the 

./data-generator.py \
--db-name=functional \
--use-hive \
--min-row-count=50 \
--max-row-count=100 \
--storage-file-formats textfile \
--use-postgresql \
--postgresql-user stakiar

and the discrepancy checker via the command:

./discrepancy-checker.py \
--db-name=functional \
--use-hive \
--use-postgresql \
--postgresql-user stakiar \
--test-db-type HIVE \
--timeout 300 \
--query-count 50 \
--profile hive

* The output of the above two commands is essentially the same as the Impala 
however, about 20% of the queries will fail when the discrepancy checker is run
* Regression testing done by running Leopard in a local VM running Ubuntu 
14.04, and by
running the discrepancy checker against Impala while inside an Impala Docker 

Change-Id: Ifb1199b50a5b65c21de7876fb70cc03bda1a9b46
M fe/src/test/resources/hive-default.xml
M tests/comparison/cli_options.py
M tests/comparison/cluster.py
M tests/comparison/data_generator.py
M tests/comparison/db_connection.py
5 files changed, 121 insertions(+), 24 deletions(-)

  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/4011/12
To view, visit http://gerrit.cloudera.org:8080/4011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb1199b50a5b65c21de7876fb70cc03bda1a9b46
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>

Reply via email to