Michael Ho has posted comments on this change. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4558/1/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: Line 304: } > reader_contexts_.clear() Done http://gerrit.cloudera.org:8080/#/c/4558/1/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: Line 167: void DeferIOContextUnregistration(DiskIoRequestContext* reader_context); > AcquireReaderContext()? Done Line 170: void UnregisterIOContexts(); > UnregisterReaderContexts()? Done http://gerrit.cloudera.org:8080/#/c/4558/1/testdata/workloads/functional-query/queries/QueryTest/single-node-topn.test File testdata/workloads/functional-query/queries/QueryTest/single-node-topn.test: Line 4: # whose children are scan nodes. When scan nodes are closed concurrently, make > I don't think the last sentence is necessary. It's likely to become stale p Rephrased the comment in the new patch. http://gerrit.cloudera.org:8080/#/c/4558/1/tests/query_test/test_queries.py File tests/query_test/test_queries.py: Line 131: def test_single_node_topn(self, vector): > This new test seems kind of misleading. The cause of this are two scan node The new test is moved to single-node-nlj.test in the new patch. Rewrote the query to be NLJ which also exercises the same path. -- To view, visit http://gerrit.cloudera.org:8080/4558 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I911fda526a99514b12f88a3e9fb5952ea4fe1973 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
