Dan Hecht has posted comments on this change.

Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr
......................................................................


Patch Set 10: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4389/10/be/src/runtime/buffered-block-mgr.cc
File be/src/runtime/buffered-block-mgr.cc:

Line 1342:   // the block and access the buffer concurrently.
Are blocks really shared across threads like that?  Anyway, fine to leave this 
but let's not bring this logic over to buffer-pool unless necessary.


http://gerrit.cloudera.org:8080/#/c/4389/10/be/src/runtime/buffered-block-mgr.h
File be/src/runtime/buffered-block-mgr.h:

PS10, Line 255: having no
              :     /// references to the data
I didn't know what this was trying to say until I saw the clearer comment in 
the .cc file.  How about something like
The read path can be decrypted in place since no one else could have a 
reference to the read buffer.


PS10, Line 656: temporary
is this talking about encrypted_write_buffer_, or something else?


-- 
To view, visit http://gerrit.cloudera.org:8080/4389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibebe431f69c3c569cbff68171beaa32ef2ab03b6
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to