Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-4232: qgen: Hive does not support aggregates inside 
specific analytic clauses
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4581/2//COMMIT_MSG
Commit Message:

Line 20: 
It's still not exactly clear to me what is not allowed. Can you give an example 
query here that is allowed in Impala but not Hive?


http://gerrit.cloudera.org:8080/#/c/4581/2/tests/comparison/query_generator.py
File tests/comparison/query_generator.py:

PS2, Line 584: funcs
It's not clear what the funcs argument means. Can you rename it something more 
descriptive and add it to the function docstring?


Line 797:       child_null_arg_pools = set()
this line and the comment above it should be right above line 805


PS2, Line 803:       
this should be 4 spaces


http://gerrit.cloudera.org:8080/#/c/4581/2/tests/comparison/query_profile.py
File tests/comparison/query_profile.py:

PS2, Line 693: get_analytics_cannot_contain_aggs
how about renaming this to allow_analytics_with_aggs?


-- 
To view, visit http://gerrit.cloudera.org:8080/4581
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1096c4cde7ea52a52b39e31cd93242da53b549f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to