Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4590/1/.clang-format File .clang-format: Line 6 > Putting short if statements on a single line is something we've definitely It's already in The Google style, so we don't need it. Line 34: DerivePointerAlignment: false > This doesn't seem relevant for Java. Done -- To view, visit http://gerrit.cloudera.org:8080/4590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccaec6c1673c3e08d2c39200b0c84437af629aed Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
