Alex Behm has posted comments on this change. Change subject: IMPALA-4042: count(distinct NULL) fails on a view ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4600/2/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: Line 734: if (smap == null || this instanceof NullLiteral) return result; This invalidates the comment above that when smap is null, this function is equivalent to clone(). I'm not convinced this is the right fix. I think the right fix it probably to use perserveRootType==true in the appropriate place. -- To view, visit http://gerrit.cloudera.org:8080/4600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf3b4511234e473e5b9548fbf3e97f333c9980f1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yonghyun Hwang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
