Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load ......................................................................
Patch Set 5: (3 comments) This looks good to me. One last thing: we should think about how we're going to monitor this. Could you add metrics to this server to measure the queue size? You can add a "InitMetrics(MetricGroup*)" call to TAcceptQueueServer, called from ThriftServer. The most important metric would be a queue length one, incremented when the accept thread adds a connection to the queue, and decremented on the other side. http://gerrit.cloudera.org:8080/#/c/4519/5//COMMIT_MSG Commit Message: PS5, Line 18: This patch has been tested locally with the repro shown in IMPALA-4135, but : it still needs to be tested in a real cluster. no longer true. Add a comment about what testing you did. http://gerrit.cloudera.org:8080/#/c/4519/5/be/src/rpc/TAcceptQueueServer.h File be/src/rpc/TAcceptQueueServer.h: PS5, Line 20: // with the : // significant changes noted inline below. strange line break in comment again PS5, Line 45: thread pool "separate thread, asynchronously. " -- To view, visit http://gerrit.cloudera.org:8080/4519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie50e728974ef31a9d49132a0b3f7cde2a4f3356d Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
