Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s ......................................................................
IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s Our SleepForMs() function relied on usleep() which sleeps for 'n' microseconds. However, the manpage for usleep() specifies that this may not work for values > 1000000 us (or 1s). This patch removes the use of usleep() and uses std::this_thread::sleep_for() instead, which was introduced with C++11. Change-Id: I06c55b1be287b264e7601c9c89788ae5929571cf Reviewed-on: http://gerrit.cloudera.org:8080/4622 Reviewed-by: Sailesh Mukil <[email protected]> Tested-by: Internal Jenkins --- M be/src/util/time.cc 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Internal Jenkins: Verified Sailesh Mukil: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06c55b1be287b264e7601c9c89788ae5929571cf Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]>
