Alex Behm has posted comments on this change. Change subject: IMPALA-4213: Planner not pushing some Kudu predicates ......................................................................
Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/4613/3//COMMIT_MSG Commit Message: Line 7: IMPALA-4213: Planner not pushing some Kudu predicates Commit msg should describe the fix, bot the problem (or JIRA title). Something like "Fix pushing predicates to Kudu that need constant folding" http://gerrit.cloudera.org:8080/#/c/4613/3/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: Line 288: predicate = KuduScanNode.normalizeSlotRefComparison(predicate, analyzer); can remove KuduScanNode Line 290: ComparisonOp op = getKuduOperator(((BinaryPredicate)predicate).getOp()); can remove cast to BinaryPredicate -- To view, visit http://gerrit.cloudera.org:8080/4613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bab22d90ee00a054c847de6c734b4f24a3f5a85 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
