Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/4349/9/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 295: private final HashMap<TableName, Table> referencedTables_ = Maps.newHashMap(); > Is this change (maintaining referenced tables cache) still required with th I agree it's not required specifically to fix the table id problem, but it generally seems saner to have the guarantee. I think we can probably come up with scenarios where not having this guarantee can cause hard-to-debug problems (which are different than the table id problems). http://gerrit.cloudera.org:8080/#/c/4349/9/fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java File fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java: Line 164: HashMap<TableName, Table> referencedTables = Maps.newHashMap(); > Same question as in referencedTables_ in Analyzer. Assuming we want to reta The map is only for validation purposes. The purpose of this map is to check that we've gotten tables from Analyzer.referencedTables_ in all code paths, so it doesn't make sense to validate with Analyzer.referencedTables_ itself. -- To view, visit http://gerrit.cloudera.org:8080/4349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
