Alex Behm has posted comments on this change. Change subject: IMPALA-4076: Fix runtime filter sort compare method ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4652/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: Line 341: } This doesn't seem quite right. A cardinality of 0 translates to a selectivity of 0 (not -1) http://gerrit.cloudera.org:8080/#/c/4652/2/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test File testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test: Line 1121: # IMPALA-4076: This query was constructed by hand to trigger the issue with sorting of Should also have brief description of the scenario being tested, something like: Test pruning the least selective runtime filters to obey QUERY_OPTION_NAME in the presence of zero-cardinality plan nodes. Line 1123: # so the number of runtime filters has to be greater than 32 and they have to be in a We should set this 32 number a part of the planner test. Otherwise, if we change default value of the query option, we may silently lose test coverage. Line 1203: inner join small_two on (True) you can remove the "on (True)" conditions -- To view, visit http://gerrit.cloudera.org:8080/4652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad433f2ece423ea29e79e81b68fa53cb0af18378 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-HasComments: Yes
